Skip to content

fix: assert object library uses spdlog::spdlog instead of fmt::fmt #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: assert object library uses spdlog::spdlog instead of fmt::fmt #5536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tiledb/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ set(TILEDB_COMMON_SOURCES ${COMMON_SOURCES} PARENT_SCOPE)
commence(object_library assert)
this_target_sources(assert.cc)
# can be removed when c++20 `<format>` is consistently supported
find_package(fmt REQUIRED)
target_link_libraries(assert PUBLIC fmt::fmt)
find_package(spdlog REQUIRED)
target_link_libraries(assert PUBLIC spdlog::spdlog)
conclude(object_library)

#
Expand Down
2 changes: 1 addition & 1 deletion tiledb/common/assert.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
#ifndef TILEDB_ASSERT_H
#define TILEDB_ASSERT_H

#include <fmt/format.h>
#include <spdlog/fmt/fmt.h>
#include <cstdlib>
#include <functional>
#include <iostream>
Expand Down
Loading