[BugFix] Discord embed, resume views, and scripts loading issues #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
requested changes
Aug 28, 2025
Comment on lines
-233
to
+240
| <script src="assets/js/jquery-3.6.1.min.js" async></script> | ||
| <script src="assets/js/jquery.scrollex.min.js" async></script> | ||
| <script src="assets/js/jquery.scrolly.min.js" async></script> | ||
| <script src="assets/js/browser.min.js" async></script> | ||
| <script src="assets/js/breakpoints.min.js" async></script> | ||
| <script src="assets/js/util.js" async></script> | ||
| <script src="assets/js/main.js" async></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/@widgetbot/html-embed@1.0.0"></script> | ||
| <script src="assets/js/jquery-3.6.1.min.js"></script> | ||
| <script src="assets/js/jquery.scrollex.min.js" ></script> | ||
| <script src="assets/js/jquery.scrolly.min.js"></script> | ||
| <script src="assets/js/browser.min.js" ></script> | ||
| <script src="assets/js/breakpoints.min.js" ></script> | ||
| <script src="assets/js/util.js" ></script> | ||
| <script src="assets/js/main.js" ></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/@widgetbot/html-embed@1.3.0"></script> |
There was a problem hiding this comment.
while this is probably a sane choice, its likely important to figure out why async was added in the first place.
i would not be surprised if it was done to cut down response time for the website which in turn increases SEO massively.
so if thats the case, just undoing this might not be a good choice given that the websites primary role is to be SE-relevant.
There was a problem hiding this comment.
Yeah, it was done in the big SEO PR: #10
There was a problem hiding this comment.
Since develop doesnt have it to begin with, merging this will hence not make the SEO worse. So we can accept this change for now.
Zabuzard
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found 3 issues:
closes #20