🎨 Return Station objects in getLatestArrivals #3565
Merged
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKrisKrisu
requested changes
May 25, 2025
| ->limit($maxCount) | ||
| ->pluck('station_id') | ||
| ->map(function (int $id) { | ||
| return Station::where('id', $id)->first(); |
There was a problem hiding this comment.
This would result in an additional $maxCounts SQL queries, which would not scale well on the production instance. :(
There was a problem hiding this comment.
That's fair and thanks for letting me know, this isn't the best solution in regards to performance as I wasn't really looking into how many queries that would add. I'll turn this into a draft PR and try to approach it in a different way.
There was a problem hiding this comment.
Went ahead and just made it so it maps the values into a new Station instance.
MartinNemi03
force-pushed
the
latest-arrivals-stations
branch
from
f6480c1 to
170f631
Compare
HerrLevin
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally meant to have this add areas to station history (thus having area in autocomplete before typing a destination) and even though it seems that attribute would just need accessing in order to write itself into the output object, it seemed kinda iffy..
So at least it now returns Station objects as commented in TODO.