-
Notifications
You must be signed in to change notification settings - Fork 452
updated loading in activation patching demo to use transformer bridge #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-3.x
Are you sure you want to change the base?
updated loading in activation patching demo to use transformer bridge #1011
Conversation
fc93245
to
739e8bf
Compare
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
@degenfabian What's up with the changes made to transformers.py in this PR? |
Cell 8 fails because the devices of the tensors differ (HookedTransformer is on cuda and TransformerBridge is on cpu). I made those changes to mimic how the device selection worked in HookedTransformer (if the user doesn't specify anything, use the best available device on the current machine). This fixed the mismatching output on my laptop, but curiously not in the CI and so far I haven't been able to figure out why. |
@degenfabian Sounds good! For something like this, that change should be a separate PR, since it may have a benefit in other places |
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
…g_demo_transformer_bridge_migration
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist: