fix(ui5-popover): render block layers in the correct order #12659
+106
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenUI5 dialogs' and the WebC dialogs' block layers are rendered in order Fixes: 12444
Collaborator
|
🚀 Deployed on https://pr-12659--ui5-webcomponents-preview.netlify.app |
Fixes failing test
Stoev
reviewed
Nov 13, 2025
Stoev
left a comment
Stoev
left a comment
There was a problem hiding this comment.
OpenUI5 dialogs' and the Web Components dialogs' block layers are rendered and displayed in the order of opened dialogs.
| </ui5-dialog> | ||
| <ui5-dialog id="newDialog1" header-text="This is an WebC Dialog 2"> | ||
| <ui5-button id="someButton">Some button</ui5-button> | ||
| <ui5-dialog id="newDialog1" draggable header-text="This is an WebC Dialog 2"> |
There was a problem hiding this comment.
Suggested change
| <ui5-dialog id="newDialog1" draggable header-text="This is an WebC Dialog 2"> | |
| <ui5-dialog id="newDialog1" draggable header-text="This is a Web Component Dialog 2"> |
| <ui5-dialog id="newDialog1" draggable header-text="This is an WebC Dialog 2"> | ||
| <ui5-button id="someButton2">Some button 1</ui5-button> | ||
| </ui5-dialog> | ||
| <ui5-dialog id="newDialog2" draggable header-text="This is an WebC Dialog 3"> |
There was a problem hiding this comment.
same as above, if appropriate, please change all entries "an WebC" to "a Web Component".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenUI5 dialogs' and the WebC dialogs' block layers are rendered and displayed in the order of opened dialogs
Fixes: #12444