Skip to content

Conversation

lowasser
Copy link
Collaborator

Work-in-progress, not ready for review, but at least putting this here to show how the parts fit together.

Will complete #1353 .

@lowasser
Copy link
Collaborator Author

(Has dependencies on #1336 and #1381 .)

@fredrik-bakke fredrik-bakke linked an issue Apr 25, 2025 that may be closed by this pull request
@lowasser lowasser marked this pull request as ready for review August 16, 2025 20:07
@lowasser
Copy link
Collaborator Author

This PR now successfully defines the product of two reals and shows it is a real number. It doesn't show any properties whatsoever of the product of two reals -- no ring laws, no nothing -- but each of those may well be its own lift.

This is the hard one. Everything else should be comparatively easy.

There are a few drive-by changes I didn't end up needing thrown in, such as that the min in an opposite order is the max in the usual order and vice versa; I can pull those out into a separate thing or leave them in...

@lowasser
Copy link
Collaborator Author

Spent an hour thinking about how to prove the ring laws, and while I think all this work is correct and is going to show up in some form, I think the right way to prove all the ring laws and the like is to make rational intervals much more full featured, and show that they are...a semiring, actually, I think. That will probably allow this to be simplified, but not by much.

@lowasser lowasser marked this pull request as ready for review October 7, 2025 14:57
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🤩

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Merging 💪

@fredrik-bakke fredrik-bakke merged commit 05c0c4f into UniMath:master Oct 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Real multiplication

2 participants