Skip to content

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Aug 27, 2025

Tidies and organizes the repository files better. Also includes some fixes I made along the way.

Reorganization

  • Move Mdbook theme from theme to website/theme.
  • Move mdbook source directory from docs to book/src.
  • place CONTRIBUTORS.md, MAINTAINERS.md and SUMMARY.md directly into the mdbook source directory. This means that the clean entrypoint in the Makefile now also deletes these.
  • Move .md docs to new docs folder, including tables as a subdirectory. (Does not include README.md, CONTRIBUTING.md, or LICENSE.md)
  • Move config files that are not required to be in the root directory to a new folder config.

Fixes

  • Header in CONTRIBUTORS.md file is now top-level
  • Disable git metadata content for STATEMENT-OF-INCLUSION.md, and rename it to STATEMENT-OF-INCLUSIVITY in line with its name in SUMMARY.md.
  • Remove the "generate main index" pre-commit hook. It should never fail on the user side, and the description was wrong.
  • Correct formatting of a contributors.py warning message.
  • Makefile clean entrypoint now also deletes profiling temp files and the pycache, and the website files can be cleaned separately with make clean-website.
  • Add description and author metadata to mdbook.
  • Editorconfig now configures Makefiles to have tab indentation.
  • Certain references were not capitalized properly.
  • A bunch of broken cases for the GitHub edit button

Resolves #1061


Comparison

  • master: 7 top-level folders, 34 top-level files
  • reorg: 7 top-level folders, 16 top-level files

@fredrik-bakke fredrik-bakke marked this pull request as ready for review August 27, 2025 13:41
@fredrik-bakke
Copy link
Collaborator Author

moving the mdbook source directory to book/src made mdbook nest the output directory to book/html/html and I haven't figured out how to make it not do it. I'm not sure I care too much though, it still works, and using book/src leads to less clutter in the editor.

@fredrik-bakke
Copy link
Collaborator Author

Also let me know if you have opinions on particular choices about the repo structuring before merging, @VojtechStep!

@VojtechStep
Copy link
Collaborator

let me know if you have opinions on particular choices about the repo structuring

I can imagine .pre-commit-config.yaml and references.bib living elsewhere, but I think the new structure is already good enough

@VojtechStep VojtechStep merged commit db4cc9d into UniMath:master Oct 8, 2025
3 checks passed
@VojtechStep
Copy link
Collaborator

Nice, thanks for taking this on!

@fredrik-bakke
Copy link
Collaborator Author

And thank you for the extremely helpful review!

@fredrik-bakke fredrik-bakke deleted the reorg branch October 8, 2025 19:32
@VojtechStep
Copy link
Collaborator

Profiling broke; I'm on it

@fredrik-bakke
Copy link
Collaborator Author

No, I'm on it

@fredrik-bakke fredrik-bakke mentioned this pull request Oct 8, 2025
@fredrik-bakke
Copy link
Collaborator Author

the profiler was a bit eager on the cleanup

fredrik-bakke added a commit that referenced this pull request Oct 9, 2025
#1500 broke the profiling CI, this fixes it I think
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factor metafiles to a subdirectory

6 participants