Add submodules of left modules over rings #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds subsets of left modules over rings. If such a subset contains the zero element/vector, is closed under addition and multiplication by a scalar from the ring, we call this subset a submodule. The PR contains a proof that the intersection of a family of submodules forms a submodule and a proof that a submodule has the structure of a module. Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
Hi Simon, welcome to agda-unimath! |
|
As a first-time contributor, don't forget to add yourself to the |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com> Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
Thank you for the review! I've pushed a commit with the suggested fixes, hope I haven't missed anything 😅 |
|
Sorry for missing that, hopefully I am closer to the coding style now |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
feat/submodules
branch
from
d430af5 to
7bfaf65
Compare
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com> Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
fredrik-bakke
approved these changes
Sep 1, 2025
|
The checks pass, so I'm merging. Thank you for the contribution, @SimonBrandner! |
|
Thank you for the review and accepting the PR! |
fredrik-bakke
pushed a commit
to fredrik-bakke/agda-unimath
that referenced
this pull request
Sep 1, 2025
This PR adds subsets of left modules over rings. If such a subset contains the zero element/vector, is closed under addition and multiplication by a scalar from the ring, we call this subset a submodule. The PR contains a proof that the intersection of a family of submodules forms a submodule and a proof that a submodule has the structure of a module. Thanks to @VojtechStep for some help along the way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds subsets of left modules over rings. If such a subset contains the zero element/vector, is closed under addition and multiplication by a scalar from the ring, we call this subset a submodule. The PR contains a proof that the intersection of a family of submodules forms a submodule and a proof that a submodule has the structure of a module.
Thanks to @VojtechStep for some help along the way!