chore: adopt new ygg-engine version #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding our worry about the engine not being in a good state if we see these exceptions, won't all future calls to the SDK continue failing? |
|
Also, it seems like yggdrasil-engine 0.4.0 is not yet available on maven central. |
Likely yes, I'm not sure, but maybe after receiving a new payload from upstream, it might eventually heal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This depends on Unleash/yggdrasil#297 and Unleash/yggdrasil#296, being released as 0.4.0.
This PR should help with #319 by not allowing wasm exceptions to propagate.
Those exceptions can still happen, but they will be logged, and the default behavior will be in place in case they do.