Get building for tvOS with newer WebRTC SDK #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanylev
force-pushed
the
vivi-12709-tvos-support
branch
from
b7465fb to
abcb990
Compare
deanylev
force-pushed
the
vivi-12709-tvos-support
branch
2 times, most recently
from
80dadad to
45b2fba
Compare
deanylev
force-pushed
the
vivi-12709-tvos-support
branch
from
45b2fba to
a52cd16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33, #28 and #35
The official Google WebRTC SDK does not have support for tvOS so I have switched over to the m125 release of https://github.com/webrtc-sdk/webrtc and updated the patches to apply onto that. I have also added more targets in the build script for tvOS devices/tvOS simulator.
I also had to make some changes to libmediasoupclient https://github.com/viviedu/libmediasoupclient and libsdptransform ibc/libsdptransform@master...viviedu:libsdptransform:vivi. We would obviously want to get these changes merged upstream and the VLprojects repos swapped back in the build script if this PR was to get merged.
I have not committed the changes from running
bump.shin this PR either, though that is of course required to try these changes out.TODO