[Rust] Don't panic when a encountering an unhandled MLIL instruction #6829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstruction `MediumLevelILInstruction` does not yet handle `MLIL_CALL_OUTPUT`, `MLIL_CALL_PARAM`, `MLIL_CALL_PARAM_SSA`, `MLIL_CALL_OUTPUT_SSA`, `MLIL_MEMORY_INTRINSIC_OUTPUT_SSA`, or `MLIL_MEMORY_INTRINSIC_SSA`. Map these to a `NotYetImplemented` kind rather than panicking since a panic takes down the entire app.
Member
|
Seems reasonable, I will cherry pick this on the cleanup branch and EDIT: Seems that the expr creation will pull the output and param, still need to add memory intrinsic however. |
Member
|
Cherry picked with 0f0321b thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediumLevelILInstructiondoes not yet handleMLIL_CALL_OUTPUT,MLIL_CALL_PARAM,MLIL_CALL_PARAM_SSA,MLIL_CALL_OUTPUT_SSA,MLIL_MEMORY_INTRINSIC_OUTPUT_SSA, orMLIL_MEMORY_INTRINSIC_SSAMap these to a
NotYetImplementedkind rather than panicking since a panic takes down the entire app.