Skip to content

Conversation

@bdash
Copy link
Contributor

@bdash bdash commented May 27, 2025

For LowLeveLIL{Expression,Instruction}<M, NonSSA> this adds:

pub fn ssa_form<'a>(&self, ssa: &'func LowLevelILFunction<M, SSA>) -> …

For LowLeveLIL{Expression,Instruction}<M, SSA> this adds:

pub fn non_ssa_form(&self, non_ssa: &'func LowLevelILFunction<M, NonSSA>) -> …

One thing I wasn't sure about is having these validate that self.function and the passed-in function represent the same underlying function object. Is there an easy way to verify that?

@bdash bdash force-pushed the rust-llil-map-ssa-to-non-ssa branch from a87589b to 80ce02d Compare May 27, 2025 19:04
@emesare emesare self-assigned this May 27, 2025
@bdash bdash force-pushed the rust-llil-map-ssa-to-non-ssa branch from 80ce02d to 431d958 Compare May 27, 2025 19:57
@bdash bdash force-pushed the rust-llil-map-ssa-to-non-ssa branch from 431d958 to b15de34 Compare May 27, 2025 19:59
@bdash
Copy link
Contributor Author

bdash commented May 27, 2025

The latest push fixed the clippy warnings the earlier iteration had introduced.

@bdash bdash force-pushed the rust-llil-map-ssa-to-non-ssa branch from b15de34 to 08d88d8 Compare May 30, 2025 00:30
@emesare
Copy link
Member

emesare commented May 31, 2025

Cherry picked on dev with 82a211d. Thank you!

@emesare emesare closed this May 31, 2025
@emesare emesare added the Component: Rust API Issue needs changes to the Rust API label May 31, 2025
@emesare emesare added this to the Helion milestone May 31, 2025
@bdash bdash deleted the rust-llil-map-ssa-to-non-ssa branch June 5, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Rust API Issue needs changes to the Rust API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants