Skip to content

[ObjC] Don't log when we encounter an objc_msgSendSuper2 call from Swift code #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

[ObjC] Don't log when we encounter an objc_msgSendSuper2 call from Swift code #7433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions plugins/workflow_objc/src/activities/super_init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,7 @@ fn return_type_for_super_init(call: &Call, view: &BinaryView) -> Option<Ref<Type

let src_var = match src.kind {
MediumLevelILLiftedInstructionKind::AddressOf(Var { src: src_var }) => src_var,
MediumLevelILLiftedInstructionKind::VarSsa(_)
| MediumLevelILLiftedInstructionKind::Sub(_) => {
_ => {
// The Swift compiler generates code that initializes the `objc_super` variable in more varied ways.
log::debug!(
" found non-address-of variable definition of `objc_super` variable at {:#0x} {:?}",
Expand All @@ -201,14 +200,6 @@ fn return_type_for_super_init(call: &Call, view: &BinaryView) -> Option<Ref<Type
);
return None;
}
_ => {
log::error!(
"Unexpected source of variable definition at {:#0x} {:x?}",
super_param_def.address,
super_param_def
);
return None;
}
};

// `src_var` is a `struct objc_super`. Find constant values assigned to the `super_class` field (second field).
Expand Down
Loading