[ObjC] Add support for removing runtime calls that perform retain count operations #7440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/workflow_objc/src/activities/remove_memory_management.rs
Outdated
Show resolved
Hide resolved
plugins/workflow_objc/src/activities/remove_memory_management.rs
Outdated
Show resolved
Hide resolved
plugins/workflow_objc/src/activities/remove_memory_management.rs
Outdated
Show resolved
Hide resolved
|
sorry, didn't mean to start separate reviews, just provide suggestions 😅 |
bdash
force-pushed
the
test_objc_remove_retain_release
branch
from
e8f0fa3 to
366da11
Compare
…nt operations A new activity is added that will remove calls to `objc_retain`, `objc_release`, `objc_autorelease`, and related functions. It is disabled by default due to the fact it changes the semantics of the code. It can be enabled on a per-function basis via the Function Settings context menu or command palette entry. Alternatively, it can be enabled in Open with Options or in user settings if a user would prefer it be on for an entire file or for all files they open. For now the activity is only eligible within arm64 binaries. Supporting x86_64 will require matching some slightly different IL patterns.
bdash
force-pushed
the
test_objc_remove_retain_release
branch
from
366da11 to
82e8eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new activity is added that will remove calls to
objc_retain,objc_release,objc_autorelease, and related functions. It is disabled by default due to the fact it changes the semantics of the code. It can be enabled on a per-function basis via the Function Settings context menu or command palette entry, or it can be enabled in Open with Options or in user settings if a user would prefer it be on for an entire file or for all files they open.For now the activity is only eligible within arm64 binaries. Supporting x86_64 will require matching some slightly different IL patterns.