vlsingle, vmsingle: do not mount emptyDir if data volume is present in spec.volumes
#1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
mount-existing-volume-as-storage
branch
from
fbeb6cd to
2bc9689
Compare
AndrewChubatiuk
force-pushed
the
mount-existing-volume-as-storage
branch
from
2bc9689 to
96465ef
Compare
f41gh7
reviewed
Jul 27, 2025
| return t.needAddLiveness | ||
| } | ||
|
|
||
| func Test_buildProbe(t *testing.T) { |
There was a problem hiding this comment.
changes to the container_test.go file looks unrelated to this PR.
There was a problem hiding this comment.
method for volumes and mounts creation was added to container.go, added tests for it to container_test.go and rewrote other tests to f-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it's only possible to set external PVC for vlsingle and vmsingle only with crutches: storageDataPath should be set using
spec.extraArgs, since default or one, which is controlled byspec.storageDataPathcreates PVC fromspec.storageor mounts emptyDir ifspec.storageis not set. any volume mounts that are mounted tospec.storageDataPathlead to collision. Even with this crutch pod has unneeded volume mount, also in vmsingle backup functionality becomes unavailable, since it also relies onspec.storageDataPathvalue.this PR moves method, which mounts storage volume to build package and does the following:
storageDataPathonly if volume with expected name is not already present inspec.volumeMountsspec.storageis definedspec.volumesUnderstand that it may cause restart for vlsingle and vmsingle pods, if there are any values defined at
spec.volumeMountsorspec.volumes, but didn't want to make function signature too heavy also not sure if this is a common case