feat: make Rectangle static for server usage #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * and will provide the value passed to this function. | ||
| */ | ||
| public delete(at: Rectangle | Point) { | ||
| public delete(at: Rectangle | Point, shouldEmitEvent: boolean = true) { |
There was a problem hiding this comment.
You are still passing a rectangle, so this doesn't accomplish anything other than no longer creating an extra function on the rectangle when it is made. This seems like a premature optimization to me. In addition, every change should trigger events, it is up to subscribers to determine whether the event is relevant. Think of it like a proxy, the caller of this function should not be aware that there are any subscribers in my opinion - the same as any other store that has a subscriber. If you want to avoid an infinite loop of events.
…ents when manually deleting poitns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.