Update use of Actor rendering class #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmorel
force-pushed
the
update-actor-usage
branch
from
470d837 to
4fde484
Compare
|
@dpugmire I usually lean on you for the rendering code in Viskores. Can you do a review of these changes. The lines are mostly documentation and style. I also added some new constructors to |
kmorel
force-pushed
the
update-actor-usage
branch
from
4fde484 to
a3cd2a0
Compare
|
@dpugmire ping |
1 similar comment
|
@dpugmire ping |
kmorel
force-pushed
the
update-actor-usage
branch
from
a3cd2a0 to
5eb35fe
Compare
When the rendering classes were originally created, `Actor` accepted the cell set, coordinate system, and field independently. More recently (but not that recently), new constructors were made that accept a `DataSet` object and pulls these out for you. This is generally a better way to construct actors, so update the documentation and testing code to follow this convention. Also added new `Actor` constructors that do not require passing the name of the coordinate system. This is for the common use case where each dataset has exactly one coordinate system.
kmorel
force-pushed
the
update-actor-usage
branch
2 times, most recently
from
3438fb4 to
bd84882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the rendering classes were originally created,
Actoraccepted the cell set, coordinate system, and field independently. More recently (but not that recently), new constructors were made that accept aDataSetobject and pulls these out for you. This is generally a better way to construct actors, so update the documentation and testing code to follow this convention.