Skip to content

fix when manually instantiating JsonpMediaTypeFormatter #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix when manually instantiating JsonpMediaTypeFormatter #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
087c9fe
fix when manually instantiating JsonpMediaTypeFormatter
MingweiSamuel Jun 27, 2016
eacfbb8
remove redundant string.format
MingweiSamuel Jun 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WebApiContrib.Formatting.Jsonp/JsonpMediaTypeFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public override async Task WriteToStreamAsync(Type type, object value, Stream st
{
// the /**/ is a specific security mitigation for "Rosetta Flash JSONP abuse"
// the typeof check is just to reduce client error noise
writer.Write("/**/ typeof " + _callback + " === 'function' && " + _callback + "(");
writer.Write("/**/typeof {0}==='function'&&{0}(", _callback ?? _callbackQueryParameter);
writer.Flush();
await _jsonMediaTypeFormatter.WriteToStreamAsync(type, value, stream, content, transportContext);
writer.Write(");");
Expand Down