[NFC][wasm-reduce] Split out DestructiveReducer #7854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Reducer class used to do double duty providing general reducer utilities and also walking the module to do destructive reduction. Split the module walking part into a new DestructiveReducer class so the Reducer class providing general utilities can be reasonably reused by new reducer classes in the future.
kripken
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reducer class used to do double duty providing general reducer
utilities and also walking the module to do destructive reduction. Split
the module walking part into a new DestructiveReducer class so the
Reducer class providing general utilities can be reasonably reused by
new reducer classes in the future.