Feature/241 filtered index ids #273
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code wise, I think we're fine. However, we'll want to test these to make sure there's no disruption in functionality. For example, filtering the
There's no "algolia-indexing" page so this is definitely a legacy detail coming from the fork. That said, when toggling on "All Posts" in autocomplete, the notice goes away. However, I don't want this to be tied to autocomplete if we can help it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of me wants to include PHPDocs for the filters, but we don't have those elsewhere in the Algolia plugin so for the moment I'm going with consistency.