fixing charset problem #1274
fixing charset problem #1274
Conversation
| @@ -201,7 +201,7 @@ class RestTestCaseWriter : HttpWsTestCaseWriter { | |||
| override fun handleVerbEndpoint(baseUrlOfSut: String, _call: HttpWsAction, lines: Lines) { | |||
|
|
|||
| val call = _call as RestCallAction | |||
| val verb = call.verb.name.lowercase(Locale.getDefault()) | |||
| val verb = call.verb.name.lowercase(Locale.ENGLISH) | |||
There was a problem hiding this comment.
looks like several places use Locale.getDefault(). can you fix all of the occurrencies in this PR? also, might be good to specify a setDefault in the main entry point (ie Main) to avoid possible issues in future
There was a problem hiding this comment.
hi @omursahin i think we should make sure we use Locale.ENGLISH and not getDefault() for a few reasons:
- setting locale as you did now in the core would not apply to driver (eg SutController)
- changing default locale on driver might impact the SUT
- future unit test cases might fail if main is not called first
we can still have a Locale.setDefault(Locale.ENGLISH) in Main as safety net, but I think all other cases should be explicit in Locale.ENGLISH
| @@ -746,7 +746,7 @@ public final boolean extractSqlDbSchemaAndConstraints(){ | |||
| fkMap.putIfAbsent(t.name, new ArrayList<>()); | |||
| if (t.foreignKeys!=null && !t.foreignKeys.isEmpty()){ | |||
| t.foreignKeys.forEach(f->{ | |||
| fkMap.get(t.name).add(f.targetTable.toUpperCase(Locale.ENGLISH)); | |||
| fkMap.get(t.name).add(f.targetTable.toUpperCase(Locale.getDefault())); | |||
There was a problem hiding this comment.
can just remove the Locale.getDefault() in all these cases. ie, calling with no input is the same as calling with Locale.getDefault(). ie, simply remove all the Locale.ENGLISH, eg f.targetTable.toUpperCase()
No description provided.