Skip to content

Remove kwargs from modbus calls #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove kwargs from modbus calls #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions custom_components/solaredge_modbus_multi/hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,10 +501,8 @@ async def modbus_read_holding_registers(self, unit, address, rcount):
self._rr_address = address
self._rr_count = rcount

kwargs = {"slave": self._rr_unit} if self._rr_unit else {}

result = await self._client.read_holding_registers(
self._rr_address, self._rr_count, **kwargs
self._rr_address, count=self._rr_count, slave=self._rr_unit
)

if result.isError():
Expand Down Expand Up @@ -552,9 +550,8 @@ async def write_registers(self, unit: int, address: int, payload) -> None:
if not self.is_connected:
await self.connect()

kwargs = {"slave": self._wr_unit} if self._wr_unit else {}
result = await self._client.write_registers(
self._wr_address, self._wr_payload, **kwargs
self._wr_address, slave=self._wr_unit, values=self._wr_payload
)

self.has_write = address
Expand Down
Loading