Skip to content

Conversation

C-Vac
Copy link

@C-Vac C-Vac commented Oct 5, 2025

I am very certain that the majority of the changes are CRLF vs LF and I'm not sure how or why but I am ready to merge the changes and say that 14.9.0 replays will be rendered with mostly 100% confidence. But also might not have run the tests. I am tired.

@C-Vac
Copy link
Author

C-Vac commented Oct 5, 2025

Okay actually tests failed for the new version, and I deleted jacuzzi and another map by accident maybe? The actual render script will render the 14.9 video so not sure why failing, will investigate.

=== short test summary info ===
FAILED tests/test_all.py::test_all[replays/122.wowsreplay] - KeyError: 'e01_Jacuzzi'
FAILED tests/test_all.py::test_all[replays/1310.wowsreplay] - KeyError: 'e13_Space_1_Defence'
FAILED tests/test_all.py::test_all[replays/149.wowsreplay] - RuntimeError: version 14_9_0 is not supported currently
FAILED tests/test_latest.py::test_one[replays/149.wowsreplay] - RuntimeError: version 14_9_0 is not supported currently
=== 4 failed, 38 passed, 5 warnings in 859.27s (0:14:19) ===

@C-Vac
Copy link
Author

C-Vac commented Oct 5, 2025

Was an issue with the venv of course, and the test with the new replay file now passes. I removed tracking of the .bak files I added by mistake.

@padtrack
Copy link
Member

padtrack commented Oct 6, 2025

  1. fix your line endings so that they are consistent with the repository
  2. delete ribbon_icons/subribbons from resources, we don't use subribbons
  3. test_latest.py is unnecessary? if it tested the latest version automatically, that would be nice, but the path in the script needs to be manually updated, so I don't think there's much utility compared to just changing the argument and running render.py manually if you wanted to e.g. specifically test the latest version on a version update
  4. you can drop the update-notes.md, i think it would be better to create it in the "Wiki" GitHub feature

i have not tried unpacking this version's assets yet, but i find it hard to believe that there is 1 line change on abilities.json and nothing else has changed (especially ships.json). can you verify?

@ridonc
Copy link

ridonc commented Oct 6, 2025

i have 14.9 working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants