Skip to content

Public release 0.10.2 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Public release 0.10.2 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
526c48a
Bump version to 0.9.4
sque Sep 27, 2017
99d49b0
Add unit-test for bug fix 38
Oct 31, 2019
45c28d3
Fix #38 crash on at init_app()
Oct 31, 2019
7df476c
Merge pull request #43 from Workable/bug/38_application_factory_crash
sque Oct 31, 2019
0b165fb
Merge branch 'develop' into feature/fix_develop_branch_version
sque Oct 31, 2019
b21fe7b
Merge pull request #44 from Workable/feature/fix_develop_branch_version
sque Oct 31, 2019
97b24b8
Bump version to v0.10.2
Oct 31, 2019
1387225
Merge branch 'staging' into release/v0.10.2
sque Oct 31, 2019
60f443c
Merge pull request #47 from Workable/release/v0.10.2
sque Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flask_log_request_id/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from . import parser


__version__ = '0.10.1'
__version__ = '0.10.2'


__all__ = [
Expand Down
2 changes: 1 addition & 1 deletion flask_log_request_id/request_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def _persist_request_id():
setattr(g, g_object_attr, self._request_id_generator())

# Register after request
if self.app.config['LOG_REQUEST_ID_LOG_ALL_REQUESTS']:
if app.config['LOG_REQUEST_ID_LOG_ALL_REQUESTS']:
app.after_request(self._log_http_event)

@staticmethod
Expand Down
8 changes: 8 additions & 0 deletions tests/request_id_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ def setUp(self):
self.app.route('/')(lambda: 'hello world')
self.app.testing = True

def test_lazy_initialization(self):
# Bug #38: https://github.com/Workable/flask-log-request-id/issues/38
request_id = RequestID()
request_id.init_app(self.app)
with self.app.test_request_context(headers={'X-Amzn-Trace-Id': 'Self=1-67891234-def;Root=1-67891233-abc'}):
self.app.preprocess_request()
self.assertEqual('1-67891234-def', current_request_id())

def test_default_request_id_parser_with_amazon(self):
RequestID(self.app)
with self.app.test_request_context(headers={'X-Amzn-Trace-Id': 'Self=1-67891234-def;Root=1-67891233-abc'}):
Expand Down