Skip to content

React 18 testing #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38,078 changes: 27,786 additions & 10,292 deletions lib/react.js

Large diffs are not rendered by default.

11,601 changes: 0 additions & 11,601 deletions lib/react_dom.js

Large diffs are not rendered by default.

38 changes: 0 additions & 38 deletions lib/react_dom_prod.js

Large diffs are not rendered by default.

13,946 changes: 0 additions & 13,946 deletions lib/react_dom_server.js

Large diffs are not rendered by default.

20 changes: 0 additions & 20 deletions lib/react_dom_server_prod.js

Large diffs are not rendered by default.

44 changes: 38 additions & 6 deletions lib/react_prod.js

Large diffs are not rendered by default.

38,078 changes: 27,786 additions & 10,292 deletions lib/react_with_addons.js

Large diffs are not rendered by default.

46 changes: 21 additions & 25 deletions lib/react_with_react_dom_prod.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/src/react_client/private_utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void validateJsApi() {
registerComponent2(() => _DummyComponent2());
_isJsApiValid = true;
} on NoSuchMethodError catch (_) {
throw Exception('react.js and react_dom.js must be loaded.');
throw Exception('react.js and react_dom.js must be loaded. This could be an indicator that React 17 is unexpectedly being loaded instead of React 18.');
} catch (_) {
throw Exception('Loaded react.js must include react-dart JS interop helpers.');
}
Expand Down