Payments page update #3257
Open
Payments page update #3257
+1,508
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adjustments - Changed the payments page to use `index.page.tsx` instead of `index.md` for better component integration. - Added `AdvantagesSection` and `ProjectCards` components to both payments and tokenization pages to enhance content presentation. - Adjusted CSS styles for improved responsiveness and layout consistency across different screen sizes. - Removed outdated security card implementation in tokenization page and replaced it with a more streamlined advantages section.
- Replaced the manual benefits list in the index page with the BenefitsSection component for improved maintainability. - Added BenefitsSection to the payments page, showcasing embedded payment use cases with new card data. - Updated ProjectCards component to support optional button text for enhanced project presentation. - Introduced new CSS styles for embedded payments icons and battle-tested project cards for better visual consistency.
…layout improvements - Integrated DeveloperResourcesSection into both payments and tokenization pages to provide developers with essential resources and community links. - Updated payment URLs for various stablecoins to direct users to relevant external resources. - Improved layout and styling for the payments integration section, ensuring better responsiveness and user experience. - Refactored CSS for shared developer tools styles between payments and tokenization pages, enhancing visual consistency.
- Simplified the hero section by removing unnecessary container classes. - Adjusted padding and margins in the payments styles to enhance layout consistency across various screen sizes. - Updated media queries to ensure better responsiveness for video content and typography on smaller devices.
…eness - Added max-width and margin adjustments to the payments integration section for better alignment on larger screens. - Implemented responsive breakpoints for the payments integration section to ensure optimal display on medium and large devices. - Introduced new styles for light mode payment logos and embedded payments icons, enhancing visual consistency across the payments page.
mDuo13
requested changes
Aug 27, 2025
| title: "Access Reliable Payments Infrastructure", | ||
| contents: [ | ||
| { | ||
| subtitle: "100% uptime since 2012", |
There was a problem hiding this comment.
I don't know who wrote this copy, but I'd say it's misleading. Most people would consider the hour-long halt in February 2025 to be not uptime, because you couldn't confirm new transactions even if the servers were up and you could still check for balances.
| </p> | ||
| <ul className="developer-tools__list"> | ||
| <FeatureItem | ||
| link="https://discord.com/invite/KTNmhJDXqa" |
There was a problem hiding this comment.
I don't like that this link takes people to Discord without warning them. I'm not sure what to expect from the link but it should probably at least be treated as an external link rather than looking the same as the "Build It Yourself" links that stay on xrpl.org.
Aside from that, Discord doesn't strike me as an "institutional DeFi" type of gathering place. It presents itself as very "gamer" centric, and while some community developers are fine with that overlap, I'm sure at least some of them are uncomfortable with it or would see it as mixing professional and non-professional concerns.
So, regardless of whether we change the link, we should at least warn people accordingly.
mDuo13
added
web dev
Co-authored-by: Rome Reginelli <rome@ripple.com>
Co-authored-by: Rome Reginelli <rome@ripple.com>
Co-authored-by: Rome Reginelli <rome@ripple.com>
Co-authored-by: Rome Reginelli <rome@ripple.com>
- Corrected the class name from `.fiipay` to `.friipay` in the _use-cases.scss file to ensure proper image rendering. - No changes made to the devportal2024-v1.css file, but it remains updated for future styling adjustments.
- Added padding to the developer tools section within the tokenization page for improved layout. - Updated CSS variables in devportal2024-v1.css for consistency and future styling adjustments.
Co-authored-by: Rome Reginelli <rome@ripple.com>
Co-authored-by: Rome Reginelli <rome@ripple.com>
- Adjusted CSS variable definitions for better alignment with design standards. - Ensured future styling adjustments can be made more easily.
|
@mDuo13 resolved all your comments, relayed feedback regarding copy and discord links down the chain, will let you know the response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.