ON-16994: Update build instructions showing how to avoid debug build #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeather-amd
approved these changes
Oct 24, 2025
Contributor
jfeather-amd
left a comment
jfeather-amd
left a comment
There was a problem hiding this comment.
Looks good, thanks. I wonder if it might be slightly more clear to show the whole make invocation with NDEBUG as an example, what do you think?
Contributor
Author
I wanted this to be the same as Onload. If it is different - it is likely to lead to confusion for users. If you believe that this should be changed here - I would advocate for Onload's instructions to me updated also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.