Skip to content

[XDP] Support subgraphs profiling graphs and kernel and new metadata handling #9224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 17, 2025
Merged

[XDP] Support subgraphs profiling graphs and kernel and new metadata handling #9224

merged 13 commits into from
Sep 17, 2025

Conversation

vipangul
Copy link
Collaborator

@vipangul vipangul commented Sep 11, 2025 •
edited
Loading

Problem solved by the commit

CR-1230523 - various subgraphs and kernel profiling settings expected.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

New feature.

How problem was solved, alternative solutions (if any) and why they were rejected

To support this completely, it takes following changes in account -
XRT changes:

  • New metadata parser using new major version 3. Please note major version 2 is not deprecated & it will handle for aie-compiler version which creates older metadata.
  • Metadata changes were needed to make AIE kernel tile mapping section self-sufficient to fetch AIE tiles, added dmaChannels
  • It now fetches graphs from the AIE kernel mapping section
  • It supports substring way of finding Graph and kernel names for profiling

Metadata changes:

  • major version is updated to 3
  • Earlier major version 2 is still supported

Risks (if any) associated the changes in the commit

Low
Please Note:

  • AIEcompiler will make default major version 3 only after this XRT commit makes it to TA & XRT & XRT_MCDM pipeline for Xoah tests.
  • Meanwhile Xoah tests can enable new metadata for applicable tests using AIE compiler switch and locally built latest XRT rpms

What has been tested and how, request additional testing if necessary

Verified original test on AIE1 & AIE2.

Documentation impact (if any)

@vipangul vipangul requested a review from pgschuey September 11, 2025 18:11
github-actions[bot]
github-actions bot reviewed Sep 11, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@vipangul
XDP support for aie trace metadata changes and subgraphs
c7dfb4d 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Removed spaces
9a0d571 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Simplified implementation and kept only required functions
2f52665 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul vipangul force-pushed the 2025.2_trace_metadata_enh_commit branch from 4269759 to 2f52665 Compare September 12, 2025 21:58
github-actions[bot]
github-actions bot reviewed Sep 12, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@vipangul
Removed unused function
1669c94 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Removed methods which were internal helper functions
e7d45d4 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Windows build fix
24ed26c 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Fixed clang warnings
69154c8 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Merge remote-tracking branch 'origin' into 2025.2_trace_metadata_enh_…
b9894f8 
…commit
@vipangul
Code changes to support dma channel names reporting for AIE kernels
1aeca1f 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul vipangul marked this pull request as ready for review September 16, 2025 04:34
@vipangul vipangul requested a review from jvillarre as a code owner September 16, 2025 04:34
github-actions[bot]
github-actions bot reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@vipangul
Addressed clang tidy suggestions
ecc2d43 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Fixed clang tidy warnings
77c46aa 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
github-actions[bot]
github-actions bot reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@vipangul
Fixed windows build warning
7ed59b8 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Yet another clang tidy fix
90ada5d 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jvillarre jvillarre merged commit 51ac67e into Xilinx:master Sep 17, 2025
61 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jvillarre jvillarre jvillarre approved these changes

@pgschuey pgschuey Awaiting requested review from pgschuey

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vipangul @jvillarre