[DRAFT][AIEX] Improve pre-sched decisions for Post-SWP candidates #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
requested review from
abhinay-anubola,
abnikant,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
andcarminati
commented
Apr 8, 2025
| @@ -190,4 +190,51 @@ bool hasUnrollPragma(const Loop *L) { | |||
| return false; | |||
| } | |||
|
|
|||
| /// Check if this block is a post-SWP candidate. | |||
| bool isPostSWPCandidate(const AIEBaseInstrInfo &TII, | |||
There was a problem hiding this comment.
Some refactoring opportunities.
mgehre-amd
pushed a commit
that referenced
this pull request
Aug 21, 2025
…ng ub.posion (#429) Values of opaque type are currently initialized to integers, which may be invalid. Instead, lower them using brace-initializers. The emitc code will represent C++.
|
I like where this PR is heading. We just have to check out QoR numbers |
andcarminati
force-pushed
the
andreu.better.control.presched
branch
from
b1428ca to
f7f5824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trial to get a more consistent behavior for the PreRA Scheduler. Currently, for example. Now, we will look only to Post-SWP potential candidates to skip the pre scheduler. The affected test also shows that we could prevent pre-scheduling of non-ZOL loops with the current approach.