Fix various compile warnings #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjh
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
| // TODO Add Call Opcode e.g. JL | ||
| default: | ||
| break; | ||
| } |
There was a problem hiding this comment.
nit: this removes a TODO
llvm/lib/Target/AIE/AIEInstrInfo.cpp
Outdated
| // const auto &TM = static_cast<const AIETargetMachine &>(MF.getTarget()); | ||
| // return getInlineAsmLength(MI.getOperand(0).getSymbolName(), | ||
| // *TM.getMCAsmInfo()); | ||
| // } |
There was a problem hiding this comment.
remove the commented code?
| o << " return nullptr;\n"; | ||
| for (unsigned int i = 0; i < PseudoInstFormats.size(); i++) | ||
| PseudoInstFormats[i].emitAlternateInstsOpcode(o, i); | ||
| o << " }\n}\n"; |
There was a problem hiding this comment.
This complicates the generator, while the code is correct. Can we disable these warnings in generated code?
| @@ -40,7 +40,8 @@ class AIE final : public TargetInfo { | |||
| uint32_t calcEFlags() const override; | |||
| RelExpr getRelExpr(RelType Type, const Symbol &S, | |||
| const uint8_t *Loc) const override; | |||
| void relocate(uint8_t *Loc, const Relocation &rel, uint64_t Val) const override; | |||
| void relocate(uint8_t *Loc, const Relocation &rel, | |||
| uint64_t Val) const override; | |||
There was a problem hiding this comment.
I'm not sure about lld coding style, but I would say that rel should be Rel.
| //73 : (symbol_addr_AR + addend ) : addr [19..0]@0 in w32[1] // with default addend 0 | ||
| // 72 : (symbol_addr_AR + addend ) : addr [19..0]@0 in w08[4] // | ||
| // with default addend 0 73 : (symbol_addr_AR + addend ) : addr [19..0]@0 | ||
| // in w32[1] // with default addend 0 |
There was a problem hiding this comment.
I think this requires a manual wrap
|
I think you should update some copyright years. |
mgehre-amd
pushed a commit
that referenced
this pull request
Aug 21, 2025
[AutoBump] Merge with fixes of b91ce7b (Oct 25) (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various compile warnings that affect builds treating warnings as errors.