[AIEX] Detach Loads from address chaining #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-Stuckmann
force-pushed
the
stuckmann.multi.block.address.clustering
branch
3 times, most recently
from
9cc7eeb to
a721d3b
Compare
andcarminati
reviewed
Aug 1, 2025
andcarminati
reviewed
Aug 1, 2025
andcarminati
reviewed
Aug 1, 2025
andcarminati
reviewed
Aug 1, 2025
andcarminati
reviewed
Aug 1, 2025
andcarminati
reviewed
Aug 1, 2025
llvm/test/CodeGen/AIE/GlobalISel/cluster-base-address-multi-mbbs.mir
Outdated
Show resolved
Hide resolved
F-Stuckmann
force-pushed
the
stuckmann.multi.block.address.clustering
branch
from
44f82c6 to
a31b4b4
Compare
|
Rebasing to remove conflicts of #646 |
F-Stuckmann
force-pushed
the
stuckmann.multi.block.address.clustering
branch
3 times, most recently
from
ae128ab to
73349a0
Compare
| if (!isPhiNeeded(MBB)) { | ||
| // Incoming values to MBB are equal, no Phi needed. | ||
| const Register IncomingReg = | ||
| CurrentChainRegBlockMap.getNewReg((*MBB.pred_begin())); |
There was a problem hiding this comment.
Nit: Spurious pair of parentheses
There was a problem hiding this comment.
I guess IncomingReg is related to the incoming value that is tracked by isPhiNeeded(). Perhaps rename it to getUniquePhiValue?
F-Stuckmann
force-pushed
the
stuckmann.multi.block.address.clustering
branch
from
73349a0 to
b7b69f3
Compare
|
Due to no improvements in pointer restoring, it has been dropped. Final QoR Program Memory -0.5 Bytes Stack no change |
F-Stuckmann
changed the title
F-Stuckmann
force-pushed
the
stuckmann.multi.block.address.clustering
branch
from
b7b69f3 to
87ad3a9
Compare
martien-de-jong
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detach loads from address chain, so that they can be scheduled as early as possible and do not delay branch decision.