[AIE2P] Remove Size Constraints for PostInc Combiner #635
+128
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-Stuckmann
requested review from
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
|
Could we have a test? |
F-Stuckmann
force-pushed
the
stuckmann.2d.3d.postinc.size
branch
3 times, most recently
from
28480a3 to
a4b6e19
Compare
|
I'm curious as to the rationale. Does it block a useful optimization? |
| @@ -313,8 +311,6 @@ std::optional<unsigned> AIE2PInstrInfo::getCombinedPostIncOpcode( | |||
| case TargetOpcode::G_INTRINSIC: | |||
| switch (cast<GIntrinsic>(PostIncI).getIntrinsicID()) { | |||
| case Intrinsic::aie2p_add_2d: | |||
| if (Size >= 1024) | |||
| return {}; | |||
There was a problem hiding this comment.
Also weird that this wasn't Size > 512
martien-de-jong
approved these changes
Sep 12, 2025
F-Stuckmann
force-pushed
the
stuckmann.2d.3d.postinc.size
branch
from
a4b6e19 to
2cf21dd
Compare
GEMM now performs vloads of 2048 bits and thus this optimization enables postincrements on these loads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Memory Size constraints for PostIncrement Selection in AIE2P.
There are no regressions in performance or PM in QoR.