-
Notifications
You must be signed in to change notification settings - Fork 153
control packet lowering for aiex.configure #2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fifield
wants to merge
22
commits into
Xilinx:main
Choose a base branch
from
fifield:control_op_pkt_cfg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c21db8
to
1420b3c
Compare
1420b3c
to
2d76cfa
Compare
be53a71
to
939b51c
Compare
939b51c
to
aae9688
Compare
aae9688
to
98834df
Compare
fixes fixup tests Move control packet data to end of runtime_sequence argument list
98834df
to
e6c0824
Compare
there is an outstanding issue with test/npu-xrt/ctrl_packet_reconfig_elf where the order of the aie.device matters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a control packet lowering of
aiex.configure
:aie-opt --convert-aie-to-control-packets
) to insert configuration control packet ops usingaiex.configure
as insertion point.aie-opt --aie-ctrl-packet-to-dma
) to be "in-place", instead of creating new control sequence.The effect of the above is to combine the control packet configuration and user control runtime sequences into one transaction binary. When used with
aiecc --aie-generate-ctrlpkt --aie-generate-elf
, the output elf will contain the combined transaction binary as well as the control packet payload.The control packet reconfiguration tests are updated to use the combined runtime sequences (instruction binaries).
Test
ctrl_packet_reconfig_elf
is updated to use the combined elf for configuration and control. The xclbin contains only the routing necessary to enable configuration with packets and all control packet configuration details are hidden from the host program: