Skip to content

Conversation

Victor-Jung
Copy link
Collaborator

@Victor-Jung Victor-Jung commented Jul 28, 2025

In the various lit.cfg.py, the regex used on the output of the xrt-smi (or xbutil) to determine which device we are using is broken for Strix Halo. Even if we don't use Strix Halo for the GitHub action CI, it's useful for developers to run the CI tests locally.

Here is the output of xrt-smi or xbutil:

Device(s) Present
|BDF             |Name            |
|----------------|----------------|
|[0000:c6:00.1]  |NPU Strix Halo  |

Changing [\|]?(\[.+:.+:.+\]).+\|(RyzenAI-(npu\d)|NPU (\w+))\W*\| to [\|]?(\[.+:.+:.+\]).+\|(RyzenAI-(npu\d)|NPU ([^\|]+))\W*\| does the trick to also match Strix Halo (with a .strip() to remove the trailing white spaces).

Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the code was already updated to for strix halo, but it didn't work? (line 152 in the original). There are more lit.cfg.py to update in programming_guide and test.

@fifield fifield requested a review from jgmelber July 28, 2025 15:06
@Victor-Jung
Copy link
Collaborator Author

Victor-Jung commented Jul 28, 2025

It looks like the code was already updated to for strix halo, but it didn't work? (line 152 in the original). There are more lit.cfg.py to update in programming_guide and test.

Yes exactly, I will also update the other lit.cfg.py

@Victor-Jung Victor-Jung self-assigned this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants