SWOP formula in rune-efficiency plugin #519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed the discusion of pr#493 Xzandro#493 (comment)
checked and fixed linting errors
|
Any reason this was closed? |
|
I got an error when opening Guild/Magic shop, but after verification this version work as intended |
|
Unfortunately this PR has conflicts. Could you do a rebase please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the discusion of pr#493, seems inactive:
#493 (comment)
Added SWOP setting and halveFlats() in rune-efficiency plugins.
Logic of lines 142,143 to review.
Can brick existing external plugin.