Skip to content

Conversation

cortinico
Copy link
Collaborator

Just keeping our Detekt version up to date

@cortinico cortinico added this to the 2.0.0 milestone May 15, 2020
@cortinico cortinico added the infra PR or Issue related to project infrastructure label May 15, 2020
@cortinico cortinico requested a review from macisamuele May 15, 2020 10:14
@macisamuele
Copy link
Collaborator

macisamuele commented May 15, 2020

@cortinico update https://github.com/Yelp/swagger-gradle-codegen/blob/master/.github/workflows/pre-merge.yaml#L16 to have green tests and then feel free to merge.

tip: as the python venv is needed to install pre-commit only, I would install 3.7 (without specifying the patch version).

PS. a list of actions have a new version, we might want to update that as well (actions/checkout, actions/setup-python

edit: @cortinico took care of the test-failures and actions update in #130

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #129   +/-   ##
=========================================
  Coverage     74.56%   74.56%           
  Complexity      173      173           
=========================================
  Files            11       11           
  Lines           684      684           
  Branches         86       86           
=========================================
  Hits            510      510           
  Misses          128      128           
  Partials         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb2f60...d5a5bc5. Read the comment docs.

@cortinico cortinico merged commit d7e75e8 into Yelp:master May 15, 2020
@cortinico cortinico deleted the detekt-to-1.9.0 branch May 15, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra PR or Issue related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants