Fix/ip address #18
Open
Fix/ip address #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcastberg that seems odd, in what cases would IP not be populated? Perhaps we add a setting to this to allow user to pull the last populated IP or have it blank? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is of interest, and I am sure that there are better ways of implementing this, and don't feel you need to merge as this may be specific to me.
I was getting notified of clients with blank IPs, and it seems that the $client->IP isn't always populated, so I added an option to add the last IP and if that was not found to used fixed IP.
I have added some features to my code for always notifying if the client is on a specific network (e.g. guest), a None notifier (e.g. just print to console, useful for debugging), and adding a comment if the mac address is randomized, and reading the mac addresses from file. I can create pull requests for these if any are of interest, but I don't want to impose.