Merging in latest changes to master #1
Conversation
Added this to the readme Make sure you also add your ssh key to the ```/YOUR_USERNAME/.ssh/authorized_keys``` list
Now we don't change the Meteor's platform code We did it before to allow to deploy app without installing the platform. Specially on CI boxes. Now, it has raised issues and we think, it needs to be handled in somewhere else. Not by mup.
Also, simplify intro to this section. The benefit of encryption should be obvious in this context.
…rebuild_inside_node_modules()
…s to the passphrase-protected ssh-key-based authentication instructions.
…rted from the JS comments in the example mup.json config file.
.html was appended and redirect to 404
|
cool, i will check it all in the morning and merge if its all ok. When i made it, it was always just waiting on Arunoda to merge it, i had just finished implementing the I use it every day for all my projects at the moment (you can do by cloning the repo and doing a npm install in the mean time) I think it wasn't merged previously as he was working on the MupX stuff. If he doesn't want to merge it in, I might make a mup2 or something in npm for it that way it can be installed from npm. |
|
Yeah, seems like I got it working over here, though it needs testing for ssl. To test it, I set it up on a sample Digital Ocean droplet and deploy a sample meteor app, also modifing my /etc/hosts file to point my ROOT_URL to the droplet IP. Worked like a charm! |
|
Hey, this is very interesting stuff and really good stuff going on. With mupx, since it's docker based I think it's hard to get this merge technically as well. |
|
Seems like the dockers can be run on some defined port , so I don't see any problems doing routing through nginx to that port which now is served by a docker container instead of the forever+node. Or am I completely wrong here? Thx for taking your time on this, because this can save a lot of money for a lot of people!! |
|
I would suggest that it got merged and we (me and @aaronthorp) help out forward-porting this to mupx |
|
Ah nope. If you are going with the docker path, we need to run the nginx also inside docker. What I mean is we need to re-write nginx stuff for mupx from scratch. Also, nginx reloading needs to be address. Without breaking connections when adding a new app or removing a one. Also, this leads to what happens if we wanna deploy on multiple servers. (Oh are we building Kubernetes) If we can figure out what we wanna do(I know you guys know that already), we can work it out for mupx. |
|
I just want multiple apps on a single server, I don't even care about |
|
Why do we need nginx running in a container btw? |
In the effort to get this nginx effort merged, I've rebased in the latest changes to master of your repository so that it gets included into the open PR 👍
Though this will need your testing to confirm we're not missing any things you've fixed, especially setting up the SSL correctly which I haven't got the possibility to test at the moment.
So let's get this merged now and make it possible for meteor devs to save some money, I myself have 7 Digital Ocean machines, I'd love to combine them as they all have a very light load.