Skip to content

Conversation

gianmarcomennecozzi
Copy link
Contributor

No description provided.

@gianmarcomennecozzi gianmarcomennecozzi linked an issue Apr 24, 2020 that may be closed by this pull request
Comment on lines -50 to -52
def test_domain_error(self):
with self.assertRaises(Exception):
DomainCertificates("this_domain_does_not_exist.com")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test removed in error or is there a reason that is it no longer relevant to test the case that a domain is not found in CT logs?

@kidmose
Copy link
Collaborator

kidmose commented Apr 28, 2020

There seems to be an error in a relevant test case, that seems like it should be solved here as it pertains to getting data from crt.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random test failures due to crt.sh

2 participants