dt_bestguess defaulted to false #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 55.81% 55.74% -0.07%
==========================================
Files 21 21
Lines 1281 1279 -2
==========================================
- Hits 715 713 -2
Misses 566 566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giopaglia
reviewed
Sep 17, 2025
Comment on lines
+1
to
+6
| # using SoleModels | ||
| # using MLJ | ||
| # using DataFrames, Random | ||
| # using DecisionTree | ||
| # const DT = DecisionTree | ||
|
|
Comment on lines
+1
to
+6
| # using SoleModels | ||
| # using MLJ | ||
| # using DataFrames, Random | ||
| # using DecisionTree | ||
| # const DT = DecisionTree | ||
|
|
Comment on lines
-173
to
+175
| dtmodel0 = @test_nowarn DecisionTree("1") | ||
| dtmodel = @test_nowarn DecisionTree(branch_r) | ||
| @test_nowarn DecisionTree(branch_r_mixed) | ||
| dtmodel0 = @test_nowarn SoleModels.DecisionTree("1") | ||
| dtmodel = @test_nowarn SoleModels.DecisionTree(branch_r) | ||
| @test_nowarn SoleModels.DecisionTree(branch_r_mixed) |
There was a problem hiding this comment.
Mh why is this needed? Is there a clash on "DecisionTree"? Maybe with MLJ?
| classlabels = nothing, | ||
| featurenames = nothing, | ||
| keep_condensed = false, | ||
| dt_bestguess = false, |
There was a problem hiding this comment.
Okay good to have a kwarg for this. Can we name it differently? Like I guess we could remove the "dt_" part, because we may want to have the same argument in other SoleModels.solemodel methods in other package extension unrelated with "decision trees".
Maybe "alphanumeric_tiebreaker", or "argmax_tiebreaker", or "tiebreaker::Symbol" that can either be :argmax or :alphanumeric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had discussed a lot on this, and we ended that using a default behaviour that mimic DecisionTree behaviour on "bestguess" guesses was the way to do, with the opportunity to specify when the behaviour should stay as original SoleModels version, or to supply custom "bestguess" function.
Now @Perro2110 is pointing out the fact that, without knowing this new feature, all the experiments and tests done before this change, give different results in the end.
And this is confusing and dangerous.
So we both decided that the way to go is to defaulting "bestguess" behaviour as it's always been, and passing an opportune karg, during the creation of the solemodel, if you want a tree that strictly behave as DecisionTree's forest.