Skip to content

dnsapi/dns_opnsense.sh: Refresh for OPNsense v25.7 series #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

dnsapi/dns_opnsense.sh: Refresh for OPNsense v25.7 series #6503

merged 1 commit into from
Sep 15, 2025
+17 −13

Conversation

benyamin-codez
Copy link
Contributor

Updates the dns_opnsense.sh Bourne shell script for OPNSense v25.7 series:

  1. Fixes historical error in rm_record() [used incorrect response variable]
  2. Improves debug messaging in rm_record()
  3. Fixes _get_root() for change in OPNsense API
    • Response is now split into pseudo-rows
    • We now iterate through pseudo-rows for matching domainname field
  4. Fixes _existingchallenge() for change in OPNsense API
    • Fixes unreliable regex for uuid
    • Adds domain regex and %domain field
  5. Fixes historical error in _existingchallenge() [incorrect variable syntax]

Resolves #6467

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2025

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

This was referenced Sep 7, 2025
Closed
Closed
@benyamin-codez
Copy link
Contributor Author

Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

No usage to update (it remains unchanged).
DNS-API-Test not applicable as the script executes against local BIND (named) instance.
Tested extensively at debug 3.

@benyamin-codez
Copy link
Contributor Author

benyamin-codez commented Sep 7, 2025 •
edited
Loading

@Neilpang @koelle25

Raised this PR against dev, closing #6492 against master. Apologies. 8^d

@benyamin-codez benyamin-codez force-pushed the dnsapi-dns_opnsense-v25.7-refresh-dev branch 2 times, most recently from d9a2f48 to 1edaffb Compare September 15, 2025 05:46
@benyamin-codez
dnsapi/dns_opnsense.sh: Refresh for OPNsense v25.7 series
d76f4b2 
Updates the dns_opnsense.sh Bourne shell script for OPNSense v25.7 series:

1. Fixes historical error in rm_record() [used incorrect response variable]
2. Improves debug messaging in rm_record()
3. Fixes _get_root() for change in OPNsense API
    * Response is now split into pseudo-rows
    * We now iterate through pseudo-rows for matching domainname field
4. Fixes _existingchallenge() for change in OPNsense API
    * Fixes unreliable regex for uuid
    * Adds domain regex and %domain field
5. Fixes historical error in _existingchallenge() [incorrect variable syntax]

Resolves acmesh-official#6467

Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
@benyamin-codez benyamin-codez force-pushed the dnsapi-dns_opnsense-v25.7-refresh-dev branch from 1edaffb to d76f4b2 Compare September 15, 2025 05:51
@benyamin-codez
Copy link
Contributor Author

@Neilpang

I've resolved the ShellCheck and shfmt errors.

I only see the DNS-API-Test fail which I don't believe applies for this one.

Is there anything else you need me to do?

@benyamin-codez
Copy link
Contributor Author

That last ShellCheck/shfmt error is in acme.sh, which I didn't touch...

@Neilpang Neilpang merged commit b4a5149 into acmesh-official:dev Sep 15, 2025
12 of 13 checks passed
This was referenced Sep 15, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benyamin-codez @Neilpang