You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code fetched the zones list with GET "zones", but the API returns at most 100 zones. Accounts with more zones failed to resolve because the target zone could be beyond that limit.
Fix: First tries direct zone access (GET "zones/${zone_name}"), bypassing the 100-zone cap and falling back to the list when needed.
Result: Supports accounts with more than 100 zones.
- Add direct zone access before falling back to zones list
- This makes zone detection more reliable and faster by attempting
to access the zone directly first, which is more efficient than
listing all zones and searching through them
Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.
Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code fetched the zones list with GET "zones", but the API returns at most 100 zones. Accounts with more zones failed to resolve because the target zone could be beyond that limit.
Fix: First tries direct zone access (GET "zones/${zone_name}"), bypassing the 100-zone cap and falling back to the list when needed.
Result: Supports accounts with more than 100 zones.