Add failing test to reproduce erroneous double-join when using pluck with ransack #1623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test that reproduces the double-join issue reported in the original issue where ransack creates duplicate joins when using
pluck
on queries that already have associations joined viaincludes
andwhere
.Problem
When using the following pattern:
Ransack erroneously creates a double-join instead of reusing the existing join from
includes
andwhere
:Expected SQL (1 join):
Actual SQL (erroneous double-join):
Changes
Visitor
,AutomatedCampaign
,AutomatedCampaignReceipt
) to reproduce the exact scenariospec/ransack/adapters/active_record/double_join_pluck_spec.rb
with a failing test that:pluck()
pluck
) work correctlyThe test currently fails as expected, providing a concrete reproduction case for this issue that can be used to verify any future fix.
Impact
This issue affects performance and can potentially cause incorrect query results when the same association is joined multiple times with different aliases.
Additional instructions:
Fixes #1108
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.