Skip to content

feat(Calendar): Added aria-current for todayDate in Calendar cell #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Shubhdeep12
Copy link
Contributor

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

#8590

📝 Test Instructions:

🧢 Your Project:

@Shubhdeep12 Shubhdeep12 marked this pull request as draft July 21, 2025 13:37
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. At a quick glance, the 'aria-current' change makes sense, but it might need some further testing with screen readers just to double check that there is an improved experience.

For the class name change, we don't support custom class names in React Spectrum (outside of UNSAFE_className). I don't think we want this on the cell.

For React Aria, custom class names are already supported on the cell via the className prop.

@Shubhdeep12
Copy link
Contributor Author

oh yes, we can pass custom className to the cell itself. I might have overlooked that and added support for setting className unnecessarily.
this makes sense, I'll update the PR to just include the aria-current change.
thanks for the review!

@Shubhdeep12 Shubhdeep12 changed the title feat(Calendar): Added aria-current for todayDate in Calendar cell and custom class support feat(Calendar): Added aria-current for todayDate in Calendar cell Jul 21, 2025
@Shubhdeep12 Shubhdeep12 requested a review from reidbarber July 21, 2025 15:11
@Shubhdeep12 Shubhdeep12 marked this pull request as ready for review July 21, 2025 15:11
@snowystinger
Copy link
Member

snowystinger commented Jul 25, 2025

I tried it out in MacOS VO. We already announce "Today", and all this adds is "current date", which seems a bit repetitive.
Screenshot 2025-07-25 at 2 53 36 pm
Would like to know if there are any other screen readers where this doesn't duplicate known information. If they are all like this, or don't say anything, then I think this is unnecessary.
@majornista anything I'm overlooking?

@snowystinger snowystinger added the waiting Waiting on Issue Author label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting on Issue Author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants