Skip to content

Conversation

tianjos
Copy link

@tianjos tianjos commented Jul 18, 2025

Hi There!

This PR provide make:router by module command.

Hope this may be helpful

@densetsuuu
Copy link
Collaborator

Hey ! Thanks for the PR, it's a very good idea 🙌

We try to keep the code as consistent as possible, could you fix the make:router command to use the already existing code ? Like for example the checkModule function from the src/utils.

For the stub, look at the make:controller command for example, we need to pass the flags to the stubs to avoid side effets, we try to extend the make commands, not replace them

One last thing regarding the module router, will the routes defined inside be registered by AdonisJS if you don't edit the .adonisrcfile ?

Once again, apart from these details, great work ! 🥇

@tianjos
Copy link
Author

tianjos commented Jul 25, 2025

H!, @densetsuuu!

Since this command doesn't exists officially, I follow the guidelines of module command.

I forgot adonisrc file totally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants