Skip to content

Commit 6dd774f

Browse files
authored
chore: import type (#171)
* chore: import type * run prettier * run lint fixes * fixup * fix lint * no jest bump * fix test * fix * fix
1 parent b8f2d1d commit 6dd774f

33 files changed

+1759
-851
lines changed

.eslintrc.js

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
module.exports = {
2-
parser: '@typescript-eslint/parser', // Specifies the ESLint parser
3-
extends: [
4-
'plugin:@typescript-eslint/recommended', // Uses the recommended rules from the @typescript-eslint/eslint-plugin
5-
'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
6-
'plugin:prettier/recommended', // Enables eslint-plugin-prettier and displays prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
2+
parser: '@typescript-eslint/parser', // Specifies the ESLint parser
3+
extends: [
4+
'plugin:@typescript-eslint/recommended', // Uses the recommended rules from the @typescript-eslint/eslint-plugin
5+
'plugin:prettier/recommended' // Enables eslint-plugin-prettier and displays prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
76
],
8-
parserOptions: {
9-
ecmaVersion: 2018, // Allows for the parsing of modern ECMAScript features
10-
sourceType: 'module', // Allows for the use of imports
7+
parserOptions: {
8+
ecmaVersion: 2018, // Allows for the parsing of modern ECMAScript features
9+
sourceType: 'module' // Allows for the use of imports
1110
},
1211
rules: {
1312
// keep imports / functions, clean, etc,
@@ -20,51 +19,49 @@ module.exports = {
2019
'@typescript-eslint/explicit-function-return-type': 0,
2120
'@typescript-eslint/interface-name-prefix': 0,
2221
'@typescript-eslint/no-explicit-any': 0,
22+
'@typescript-eslint/consistent-type-imports': ['error', { prefer: 'type-imports' }],
2323
'prefer-const': 0
2424
},
2525
env: {
2626
browser: true,
27-
node: false,
27+
node: false
2828
},
2929
overrides: [
3030
// node files
3131
{
32-
files: [
33-
'.eslintrc',
34-
'bin/**',
35-
],
32+
files: ['.eslintrc', 'bin/**'],
3633
parserOptions: {
3734
sourceType: 'script',
38-
ecmaVersion: 2015,
35+
ecmaVersion: 2015
3936
},
4037
env: {
4138
browser: false,
4239
node: true,
43-
es6: true,
40+
es6: true
4441
},
4542
plugins: ['node', 'import'],
46-
extends: 'plugin:node/recommended',
43+
extends: 'plugin:node/recommended'
4744
},
4845

4946
// typescript node files
5047
{
5148
files: ['rollup.config.ts'],
5249
rules: {
53-
'@typescript-eslint/no-var-requires' : 'off',
50+
'@typescript-eslint/no-var-requires': 'off'
5451
}
5552
},
5653

5754
// bin files
5855
{
5956
files: ['bin/**'],
60-
// eslint-disable-next-line node/no-unpublished-require
57+
// eslint-disable-next-line @typescript-eslint/no-var-requires
6158
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
6259
'no-console': 'off',
6360
'no-process-exit': 'off',
6461
'@typescript-eslint/no-var-requires': 'off',
6562
'node/no-unpublished-require': 'off',
6663
'node/shebang': 'off'
67-
}),
68-
},
64+
})
65+
}
6966
]
7067
};

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export default class FormComponent {
107107
onSubmit() {
108108
try {
109109
await this.changeset.validate(changes => UserSchema.validate(changes));
110+
this.changeset.removeError()
110111
} catch (e) {
111112
dummyChangeset.addError(e.path, { value: changeset.get(e.path), validation: e.message });
112113
}

0 commit comments

Comments
 (0)