feat: adding support for dynamic rackid assignment after pod schedule [KO-385] #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
requested changes
May 23, 2025
pkg/utils.go
Outdated
| return networkIPs, nil | ||
| } | ||
|
|
||
| func (initp *InitParams) getRackIDFromVolume(hostPath string, isPodRestart bool) (int, error) { |
There was a problem hiding this comment.
This is actually the absolute filePath not hostPath. Change the comments and all below accordingly.
Suggested change
| func (initp *InitParams) getRackIDFromVolume(hostPath string, isPodRestart bool) (int, error) { | |
| func (initp *InitParams) getRackIDFromVolume(filePath string, isPodRestart bool) (int, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.