Add wait for migration flow before deletion of pod [KO-444] #404
+147
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwalantmodi05
requested review from
tanmayja and
abhishekdwivedi3060
as code owners
abhishekdwivedi3060
requested changes
Sep 4, 2025
tanmayja
reviewed
Sep 26, 2025
test/cluster/cluster_helper.go
Outdated
| for idx := range podList.Items { | ||
| pod := &podList.Items[idx] | ||
|
|
||
| asinfo, err := getASInfo(logger, k8sClient, ctx, clusterNamespacedName, pod.Name, "statistics") |
There was a problem hiding this comment.
cross-check how to call getASInfo() function, last argument "statistics" passsed here is not correct.
abhishekdwivedi3060
requested changes
Sep 29, 2025
abhishekdwivedi3060
approved these changes
Oct 3, 2025
tanmayja
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.