Skip to content

Conversation

@dougbtv
Copy link

@dougbtv dougbtv commented May 9, 2024

Only runs git pull when AUTO_UPDATE is set, otherwise, installs all requirements.

(Still WIP, working on testing the fix)

Fixes #68

Only runs git pull when AUTO_UPDATE is set, otherwise, installs all requirements.
fi
fi

printf "Ensuring node requirements: %s...\n" "${repo}"
Copy link
Author

@dougbtv dougbtv May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my main concern is that this is kind of noisy output in cases when most are already installed? Maybe there's a more elegant way to check if any need update install before output? Feedback welcome of course.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(umm, including the lines below too, that suffers the same ills I'd wager)

@dougbtv
Copy link
Author

dougbtv commented May 9, 2024

Figured out I can test by setting PROVISIONING_SCRIPT to https://raw.githubusercontent.com/dougbtv/comfyui/provisioning-node-requirements/config/provisioning/default.sh

(and by editing the NODES array at the top of the file with the custom nodes in question in my situation...)

@dougbtv
Copy link
Author

dougbtv commented May 9, 2024

"works on my (cloudified) machine" with PROVSIONING_SCRIPT set to:

https://raw.githubusercontent.com/dougbtv/comfyui/provisioning-node-requirements-tester/config/provisioning/default.sh

Which includes this diff plus a couple items in the NODES array that I had installed with manager.

...It's got me thinking if it needs changes to scan for the installed nodes? unsure.

@robballantyne robballantyne force-pushed the main branch 3 times, most recently from 22a7ac1 to 199ee29 Compare November 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom nodes, imports fails. Moving mamba env to workspace?

1 participant