move all reusable cluster config into a json that can be saved in secret #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
cluster-save-params
branch
from
cc55e29 to
c7696fc
Compare
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
cluster-save-params
branch
from
c7696fc to
a6f7a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things.
First, it makes the code much more readable, as all of the config is not 20 parameters passed to
cluster.New(), but instead is a single struct, with a few parameters that should not be stored in the cluster secret.Second, it saves all of that config into the cluster secret, so that it can be leveraged when running in the cluster.
At this point, it pivots to the cluster, everything is stored there. It does not yet run successfully from inside the cluster, as it does not leverage all of the secret information. That will be the next step.